fix(controls): Fix unconditional HwndProcEventArgs creation in TitleBar window procedure #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar window procedure
github-actions
bot
added
controls
apachezy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
In the current implementation, the
TitleBarwindow procedure always creates a newHwndProcEventArgsobject for each window message—even when there are no subscribers to theWndProcInvokedevent. This results in unnecessary object allocations and performance overhead, particularly during high-frequency message processing.Issue Number: N/A
What is the new behavior?
The
TitleBarnow checks whether any handlers are attached to theWndProcInvokedevent before instantiating theHwndProcEventArgs. If no subscribers are present, the event argument object is not created, eliminating the associated allocation cost. This change is transparent to existing API consumers and does not affect any functional behavior.Other information