Fix: ResizeMode="NoResize" ignored in FluentWindow after PR #1560#1714
Draft
Copilot wants to merge 2 commits into
Draft
Fix: ResizeMode="NoResize" ignored in FluentWindow after PR #1560#1714Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…esting Agent-Logs-Url: https://github.com/lepoco/wpfui/sessions/0c1b6b29-703c-4891-a319-5c4b5ccf0ffb Co-authored-by: pomianowski <13592821+pomianowski@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix FluentWindow resizing issue with ResizeMode property
Fix: ResizeMode="NoResize" ignored in FluentWindow after PR #1560
May 13, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1560 introduced
TitleBar.WindowResize.csfor border resize hit-testing, but did not guard againstResizeMode="NoResize"orResizeMode="CanMinimize". TheMath.Max(2, …)floor in the DPI helpers ensured the border hit zone was always ≥2px — overridingFluentWindow.SetWindowChrome()'sResizeBorderThickness = default— so windows remained draggable regardless ofResizeMode.Pull request type
What is the current behavior?
Setting
ResizeMode="NoResize"orResizeMode="CanMinimize"on aFluentWindowhas no effect — the window edges still show resize cursors and can be dragged to resize.What is the new behavior?
GetWindowBorderHitTestResultchecks the parent window'sResizeModebefore performing any border hit-testing.ResizeModeisNoResizeorCanMinimize, it returnsHTNOWHEREimmediately, suppressing resize cursors and drag-resize entirely.Other information
Regression introduced by #1560.