This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Do not block when connecting socket#62
Open
neg3ntropy wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks, I'll see why unit tests are failing. |
|
@soulrebel can you rebase this PR? |
Author
|
Sorry guys, I have now moved to other projects, technologies and even languages to help out on this. |
|
Good for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was running some tests in a Tornado web application that uses tornado-redis after a call to IOLoop.set_blocking_log_threshold() with a low value, to spot any blocking IO or slow sections.
This was the most recurring problem:
The connection is in fact opened in blocking mode.
After this patch the problem goes away and my app seems to work.
I did not run any unit test and I am aware that this probably needs some more work, for example on connection errors.
However I urge you to try and fix this and put out a new release as it quite critical to block the IOLoop even for a small time.
Thank you