This repository was archived by the owner on Apr 3, 2019. It is now read-only.
remove called unsubscribe callbacks from list of callbacks#95
Open
sjhewitt wants to merge 1 commit into
Open
Conversation
|
Any update on this? I'm seeing leaking clients when unsubscribing. |
|
@sjhewitt If you push/amend the commit, travis will try again, looks like the failures weren't related to your changes. |
Author
|
Can you create a failing test case or bit of example code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When unsubscribing from pubsub channels, a reference to expired callbacks was kept.
This change updates the
unsubscribe_callbackslist to remove references once a callback has been called