make gpud port number configurable#1199
Open
aimichal wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1199 +/- ##
==========================================
- Coverage 70.01% 70.01% -0.01%
==========================================
Files 339 339
Lines 24229 24237 +8
==========================================
+ Hits 16965 16970 +5
- Misses 6164 6166 +2
- Partials 1100 1101 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gyuho
reviewed
Jan 25, 2026
gyuho
reviewed
Jan 25, 2026
Member
|
@aimichal The different port for listener is already supported by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to be able to choose the port number that gpud exposes.
This change renames
DefaultGPUdPorttodefaultGPUdPortto scope its visibility to the config package, and exposes a functionGPUdPortNumber()that reads env var GPUD_PORT but falls back to defaultGPUdPort if it's missing or not an int.It would be nice to factor this such that the port number is considered only when building the config (in DefaultConfig()) with a nice error message if it's malformed. But today
DefaultGPUdPort(nowGPUdPortNumber()is used throughout the codebase, so I decided to propose this surgical change to start.