feat(session): add single-connection transport#1270
Draft
cardyok wants to merge 3 commits into
Draft
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
+ Coverage 90.68% 90.72% +0.03%
==========================================
Files 351 353 +2
Lines 26997 27346 +349
==========================================
+ Hits 24482 24809 +327
- Misses 1702 1719 +17
- Partials 813 818 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Exclude generated protocol stubs from patch coverage while exercising the reconnect, heartbeat, endpoint, and error-classification behavior directly. Co-Authored-By: Codex <noreply@openai.com>
Verify a parent cancellation during the active stream stops the v2 retry loop without scheduling another connection. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpud upand auto-update, and reconnect either transport after token rotationoriginmetadata required by the gateway CSRF filterRollout
v1remains the default.v2is enabled explicitly with--session-protocol=v2only after the matching Lepton gateway and gpud-manager changes are deployed.autofalls back only when the v2 service returns gRPCUNIMPLEMENTED.Related Lepton MR: https://gitlab-master.nvidia.com/dgxc-lepton/lepton/-/merge_requests/7763
Verification
go build ./...go test -race -gcflags='all=-N -l' ./pkg/session/... ./pkg/gpud-manager/systemd ./pkg/config ./cmd/gpud/command ./cmd/gpud/run ./cmd/gpud/up -count=1Full
go test -gcflags='all=-N -l' ./... -count=1is blocked by existing environment-sensitive tests: Docker ping does not time out when no daemon is available, and the pstore restricted-file assertion is not valid under the current runner permissions. All changed-package tests pass.DEV end-to-end rollout validation is deferred until the paired Lepton changes are available.
Jira
LEP-5352