feat(nvidia/xid): use common events DB for NVML-based xid watcher, disable NVML Xid event watcher in favor of "dmesg" watcher, deprecate redundant "error-xid-sxid" component #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
- Coverage 22.94% 22.68% -0.27%
==========================================
Files 296 291 -5
Lines 26851 26161 -690
==========================================
- Hits 6161 5934 -227
+ Misses 20062 19614 -448
+ Partials 628 613 -15 ☔ View full report in Codecov by Sentry. |
|
Can we add tests? |
gyuho
force-pushed
the
xid-nvml-with-common-pkg
branch
from
604dba8 to
d253b2d
Compare
gyuho
force-pushed
the
xid-nvml-with-common-pkg
branch
from
d253b2d to
5c59d46
Compare
gyuho
changed the title
xiang90
reviewed
Feb 4, 2025
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
gyuho
force-pushed
the
xid-nvml-with-common-pkg
branch
from
3b01803 to
94b01db
Compare
xiang90
reviewed
Feb 5, 2025
cardyok
reviewed
Feb 5, 2025
Signed-off-by: Gyuho Lee <[email protected]>
gyuho
force-pushed
the
xid-nvml-with-common-pkg
branch
from
49dea12 to
16f01ff
Compare
Signed-off-by: Gyuho Lee <[email protected]>
cardyok
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f., #336