Reintroduce auto live reload protocol option#4265
Open
veigaribo wants to merge 3 commits intoleptos-rs:mainfrom
Open
Reintroduce auto live reload protocol option#4265veigaribo wants to merge 3 commits intoleptos-rs:mainfrom
auto live reload protocol option#4265veigaribo wants to merge 3 commits intoleptos-rs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Substitutes #4257 for #4224, which is a breaking change intended for an eventual 0.9 release.
Additionally makes the
leptos_config::ReloadWSProtocolandleptos_config::Envenums non exhaustive, since simply adding configuration options should probably not be a breaking change. However, this makes it so that thematchin theAutoReloadcomponent needs to have a default pattern case for unknown variants, since it's from a different crate than the enum. This means that adding new variants toReloadWSProtocolwithout handling it in the component will not cause any error and will silently not work. I hate this, but I don't see a solution.