Implement Params derive macro without nightly #4514
+40
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experimenting with trying to get my app rely less on nightly rust (as I am starting to get annoyed by the frequent ICE's).
I found a TODO that was asking to do the IntoParam implementation in a non-nightly way. Looking a bit around I found several methods of doing that. In the end, this one seemed to lead to the simplest implementation. It's based on the fact that the compiler will pick the inherent impl of a function over the trait impl.
Please note that my implementation also allows the user to override the default behavior by providing their own
IntoParamimplementations for their own types. I am unsure if that is desired or not, but we could change it in case it's not.