Conversation
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>
Signed-off-by: Tiemen Schuijbroek <t.j.l.schuijbroek@ratio-case.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on top of #4473 to support better patching for keyed store fields. Currently,
.patch()works onVec<_>fields but does an unkeyed list diff: i.e., if you patchvec![0, 1, 2]againstvec![2, 1, 0], it will act as if0and2have both changed values, rather than simply noting that they've been reordered.This PR adds proper patching for keyed fields by using their key function. Currently it only does this for
Vec<_>but this can easily be extended to add support for map types (which are easier) or other collections by implementing thePatchFieldKeyedtrait on the collection type.