Python3 fixes for RealSpaceInterface #394
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RealSpaceInterface doesn't work out of the box with python3. This fixes a number of things, including integer division and some type issues related to JSON encoding. Also makes the database pickle read/writes in binary, which also fixes some type issues.
Author
|
This would clearly supersede #250 which was done on an older version. |
Owner
|
Dear @timothydmorton , I am very sorry for not following up on this, the RealSpaceInterface went out of our mind for a few years. Your PR is incredibly useful. I checked that it still works with the current CLASS version. We will incorporate these fixes in the next CLASS release (sometimes soon) with some acknowledgements for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RealSpaceInterface doesn't work out of the box with python3. This fixes a number of things, including integer division and some type issues related to JSON encoding. Also makes the database pickle read/writes in binary, which also fixes some type issues.