fix: update header parsing to use isToken function and add tests for valid tokens

[youzhixiaomutou]

#481

[Copilot]

Pull Request Overview

This PR fixes HTTP header parsing by updating the validation logic to use the isToken function instead of isAlpha, ensuring compliance with HTTP RFC specifications for valid token characters in header field names.

• Updates header parsing logic to use isToken function for more comprehensive character validation
• Adds comprehensive test coverage for valid HTTP header token characters including numeric and special characters

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
nbhttp/parser.go	Updates header parsing validation from isAlpha to isToken function
nbhttp/parser_test.go	Adds new test function to validate numeric and special characters in header names

Comments suppressed due to low confidence (1)

nbhttp/parser_test.go:47

• The test only covers numeric characters in header names. Consider adding separate test cases for individual character categories (numbers, special characters) and edge cases like empty headers or invalid characters to improve test coverage and clarity.

	data := []byte("POST / HTTP/1.1\r\n123456789: value \r\n\r\n")

[Copilot]

[nitpick] The special characters test uses all valid token characters in a single header name. Consider testing these characters individually or in smaller groups to make test failures easier to diagnose and ensure each character is properly validated.

Suggested change

	data := []byte("POST / HTTP/1.1\r\n123456789: value \r\n\r\n")
	err := testParser(t, false, data)
	if err != nil {
	t.Fatalf("test failed: %v", err)
	}
	data = []byte("POST / HTTP/1.1\r\n!#$%&'*+-.^_`|~: value \r\n\r\n")
	err = testParser(t, false, data)
	if err != nil {
	t.Fatalf("test failed: %v", err)
	}
	// Test numeric characters
	data := []byte("POST / HTTP/1.1\r\n123456789: value \r\n\r\n")
	err := testParser(t, false, data)
	if err != nil {
	t.Fatalf("test failed: %v", err)
	}
	// Test special characters in smaller groups
	data = []byte("POST / HTTP/1.1\r\n!#$%&'*: value \r\n\r\n")
	err = testParser(t, false, data)
	if err != nil {
	t.Fatalf("test failed: %v", err)
	}
	data = []byte("POST / HTTP/1.1\r\n+-.^_: value \r\n\r\n")
	err = testParser(t, false, data)
	if err != nil {
	t.Fatalf("test failed: %v", err)
	}
	data = []byte("POST / HTTP/1.1\r\n`|~: value \r\n\r\n")
	err = testParser(t, false, data)
	if err != nil {
	t.Fatalf("test failed: %v", err)
	}

[lesismal]

非常感谢！