[Cleanup] Reduce bin size when using timing stats

Reduce macro code

Author: TD-er

src/src/DataStructs/TimingStats.cpp

@@ -258,13 +258,31 @@ const __FlashStringHelper * getMiscStatsName_F(int stat) {
 
 String getMiscStatsName(int stat) {
   if (stat >= C001_DELAY_QUEUE && stat <= C025_DELAY_QUEUE) {
-    String result;
-    result.reserve(16);
-    result  = F("Delay queue ");
-    result += get_formatted_Controller_number(static_cast<cpluginID_t>(stat - C001_DELAY_QUEUE + 1));
-    return result;
+    return concat(
+      F("Delay queue "), 
+      get_formatted_Controller_number(static_cast<cpluginID_t>(stat - C001_DELAY_QUEUE + 1)));
   }
   return getMiscStatsName_F(stat);
 }
 
+void stopTimerTask(int T, int F, uint64_t statisticsTimerStart)
+{
+  if (mustLogFunction(F)) pluginStats[(T) * 256 + (F)].add(usecPassedSince(statisticsTimerStart));
+}
+
+void stopTimerController(int T, CPlugin::Function F, uint64_t statisticsTimerStart)
+{
+  if (mustLogCFunction(F)) controllerStats[(T) * 256 + static_cast<int>(F)].add(usecPassedSince(statisticsTimerStart));
+}
+
+void stopTimer(int L, uint64_t statisticsTimerStart)
+{
+  if (Settings.EnableTimingStats()) { miscStats[L].add(usecPassedSince(statisticsTimerStart)); }
+}
+
+void addMiscTimerStat(int L, int64_t T)
+{
+  if (Settings.EnableTimingStats()) { miscStats[L].add(T); }
+}
+
 #endif // if FEATURE_TIMING_STATS

src/src/DataStructs/TimingStats.h

@@ -129,23 +129,25 @@ const __FlashStringHelper * getCPluginCFunctionName(CPlugin::Function function);
 bool   mustLogCFunction(CPlugin::Function function);
 String getMiscStatsName(int stat);
 
+void   stopTimerTask(int T, int F, uint64_t statisticsTimerStart);
+void   stopTimerController(int T, CPlugin::Function F, uint64_t statisticsTimerStart);
+void   stopTimer(int L, uint64_t statisticsTimerStart);
+void   addMiscTimerStat(int L, int64_t T);
 
 extern std::map<int, TimingStats> pluginStats;
 extern std::map<int, TimingStats> controllerStats;
 extern std::map<int, TimingStats> miscStats;
 extern unsigned long timingstats_last_reset;
 
 # define START_TIMER const uint64_t statisticsTimerStart(getMicros64());
-# define STOP_TIMER_TASK(T, F) \
-  if (mustLogFunction(F)) pluginStats[(T) * 256 + (F)].add(usecPassedSince(statisticsTimerStart));
-# define STOP_TIMER_CONTROLLER(T, F) \
-  if (mustLogCFunction(F)) controllerStats[(T) * 256 + static_cast<int>(F)].add(usecPassedSince(statisticsTimerStart));
+# define STOP_TIMER_TASK(T, F) stopTimerTask(T, F, statisticsTimerStart);
+# define STOP_TIMER_CONTROLLER(T, F) stopTimerController(T, F, statisticsTimerStart);
 
 // #define STOP_TIMER_LOADFILE miscStats[LOADFILE_STATS].add(usecPassedSince(statisticsTimerStart));
-# define STOP_TIMER(L) if (Settings.EnableTimingStats()) { miscStats[L].add(usecPassedSince(statisticsTimerStart)); }
+# define STOP_TIMER(L) stopTimer(L, statisticsTimerStart);
 
 // Add a timer statistic value in usec.
-# define ADD_TIMER_STAT(L, T) if (Settings.EnableTimingStats()) { miscStats[L].add(T); }
+# define ADD_TIMER_STAT(L, T) addMiscTimerStat(L, T);
 
 #else // if FEATURE_TIMING_STATS