Skip to content

Add accounturi to dns-persist-01 challenges #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beautifulentropy merged 2 commits into from
Apr 20, 2026
Merged

Add accounturi to dns-persist-01 challenges #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78a54ac
Add accounturi to dns-persist-01 challenges
felixfontein Apr 1, 2026
7a35adb
Add comment that reusing the Host header in the account URI is OK for…
felixfontein Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions acme/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ type Challenge struct {
URL string `json:"url"`
Token string `json:"token,omitempty"`
Status string `json:"status"`
AccountURI string `json:"accounturi,omitempty"`
IssuerDomainNames []string `json:"issuer-domain-names,omitempty"`
Validated string `json:"validated,omitempty"`
Error *ProblemDetails `json:"error,omitempty"`
Expand Down
4 changes: 4 additions & 0 deletions wfe/wfe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1625,6 +1625,10 @@ func (wfe *WebFrontEndImpl) makeChallenge(
}
if chalType == acme.ChallengeDNSPersist01 {
chal.IssuerDomainNames = append([]string(nil), wfe.caaIdentities...)
// Note: By using web.relativeEndpoint here, Pebble will reflect the Host header
// into the accountURI here. This would not be acceptable in a security-conscious
// context, but is okay for Pebble.
chal.AccountURI = wfe.relativeEndpoint(request, fmt.Sprintf("%s%s", acctPath, authz.Order.AccountID))
Comment thread
felixfontein marked this conversation as resolved.
}

// Add it to the in-memory database
Expand Down
Loading