-
Notifications
You must be signed in to change notification settings - Fork 1
comment structure
Shunsuke Wada edited this page Mar 12, 2016
·
1 revision
https://github.com/elixir-lang/elixir/pull/4021
ex(5)> Tentacat.Issues.Comments.list("elixir-lang", "elixir", 4021)
[%{"body" => "@josevalim Would it make sense to provide support for `parse_head!/2` also?",
"created_at" => "2015-12-01T15:06:37Z",
"html_url" => "https://github.com/elixir-lang/elixir/pull/4021#issuecomment-160994632",
"id" => 160994632,
"issue_url" => "https://api.github.com/repos/elixir-lang/elixir/issues/4021",
"updated_at" => "2015-12-01T15:06:37Z",
"url" => "https://api.github.com/repos/elixir-lang/elixir/issues/comments/160994632",
"user" => %{"avatar_url" => "https://avatars.githubusercontent.com/u/34700?v=3",
"events_url" => "https://api.github.com/users/milmazz/events{/privacy}",
"followers_url" => "https://api.github.com/users/milmazz/followers",
"following_url" => "https://api.github.com/users/milmazz/following{/other_user}",
"gists_url" => "https://api.github.com/users/milmazz/gists{/gist_id}",
"gravatar_id" => "", "html_url" => "https://github.com/milmazz",
"id" => 34700, "login" => "milmazz",
"organizations_url" => "https://api.github.com/users/milmazz/orgs",
"received_events_url" => "https://api.github.com/users/milmazz/received_events",
"repos_url" => "https://api.github.com/users/milmazz/repos",
"site_admin" => false,
"starred_url" => "https://api.github.com/users/milmazz/starred{/owner}{/repo}",
"subscriptions_url" => "https://api.github.com/users/milmazz/subscriptions",
"type" => "User", "url" => "https://api.github.com/users/milmazz"}},
%{"body" => "@milmazz the implementation should be a bit different. We should actually raise one specific error after parsing everything that will contain everything that goes wrong, so we can show everything detailed to the user. In other words, it should be able to build `parse!` on top of the existing parse, instead of relying on the pedantic flag and raising on every error.\r\n",
"created_at" => "2015-12-01T15:23:32Z",
"html_url" => "https://github.com/elixir-lang/elixir/pull/4021#issuecomment-161000010",
"id" => 161000010,
"issue_url" => "https://api.github.com/repos/elixir-lang/elixir/issues/4021",
"updated_at" => "2015-12-01T15:23:32Z",
"url" => "https://api.github.com/repos/elixir-lang/elixir/issues/comments/161000010",
"user" => %{"avatar_url" => "https://avatars.githubusercontent.com/u/9582?v=3",
"events_url" => "https://api.github.com/users/josevalim/events{/privacy}",
"followers_url" => "https://api.github.com/users/josevalim/followers",
"following_url" => "https://api.github.com/users/josevalim/following{/other_user}",
"gists_url" => "https://api.github.com/users/josevalim/gists{/gist_id}",
"gravatar_id" => "", "html_url" => "https://github.com/josevalim",
"id" => 9582, "login" => "josevalim",
"organizations_url" => "https://api.github.com/users/josevalim/orgs",
"received_events_url" => "https://api.github.com/users/josevalim/received_events",
"repos_url" => "https://api.github.com/users/josevalim/repos",
"site_admin" => false,
"starred_url" => "https://api.github.com/users/josevalim/starred{/owner}{/repo}",
"subscriptions_url" => "https://api.github.com/users/josevalim/subscriptions",
"type" => "User", "url" => "https://api.github.com/users/josevalim"}},
%{"body" => "@josevalim Oh!, I see. I'll work on this :bowtie:\r\n\r\nThanks for the advice!",
"created_at" => "2015-12-01T15:48:16Z",
"html_url" => "https://github.com/elixir-lang/elixir/pull/4021#issuecomment-161006809",
"id" => 161006809,
"issue_url" => "https://api.github.com/repos/elixir-lang/elixir/issues/4021",
"updated_at" => "2015-12-01T15:48:16Z",
"url" => "https://api.github.com/repos/elixir-lang/elixir/issues/comments/161006809",
"user" => %{"avatar_url" => "https://avatars.githubusercontent.com/u/34700?v=3",
"events_url" => "https://api.github.com/users/milmazz/events{/privacy}",
"followers_url" => "https://api.github.com/users/milmazz/followers",
"following_url" => "https://api.github.com/users/milmazz/following{/other_user}",
"gists_url" => "https://api.github.com/users/milmazz/gists{/gist_id}",
"gravatar_id" => "", "html_url" => "https://github.com/milmazz",
"id" => 34700, "login" => "milmazz",
"organizations_url" => "https://api.github.com/users/milmazz/orgs",
"received_events_url" => "https://api.github.com/users/milmazz/received_events",
"repos_url" => "https://api.github.com/users/milmazz/repos",
"site_admin" => false,
"starred_url" => "https://api.github.com/users/milmazz/starred{/owner}{/repo}",
"subscriptions_url" => "https://api.github.com/users/milmazz/subscriptions",
"type" => "User", "url" => "https://api.github.com/users/milmazz"}},
%{"body" => "@josevalim Better? Any feedback is more than welcome. Thanks!",
"created_at" => "2015-12-01T20:19:15Z",
"html_url" => "https://github.com/elixir-lang/elixir/pull/4021#issuecomment-161083819",
"id" => 161083819,
"issue_url" => "https://api.github.com/repos/elixir-lang/elixir/issues/4021",
"updated_at" => "2015-12-01T20:19:15Z",
"url" => "https://api.github.com/repos/elixir-lang/elixir/issues/comments/161083819",
"user" => %{"avatar_url" => "https://avatars.githubusercontent.com/u/34700?v=3",
"events_url" => "https://api.github.com/users/milmazz/events{/privacy}",
"followers_url" => "https://api.github.com/users/milmazz/followers",
"following_url" => "https://api.github.com/users/milmazz/following{/other_user}",
"gists_url" => "https://api.github.com/users/milmazz/gists{/gist_id}",
"gravatar_id" => "", "html_url" => "https://github.com/milmazz",
"id" => 34700, "login" => "milmazz",
"organizations_url" => "https://api.github.com/users/milmazz/orgs",
"received_events_url" => "https://api.github.com/users/milmazz/received_events",
"repos_url" => "https://api.github.com/users/milmazz/repos",
"site_admin" => false,
"starred_url" => "https://api.github.com/users/milmazz/starred{/owner}{/repo}",
"subscriptions_url" => "https://api.github.com/users/milmazz/subscriptions",
"type" => "User", "url" => "https://api.github.com/users/milmazz"}},
%{"body" => "@milmazz yes, this is a perfect starting point. :) I will review with more care soon after 1.2 is out, thank you!",
"created_at" => "2015-12-02T07:34:41Z",
"html_url" => "https://github.com/elixir-lang/elixir/pull/4021#issuecomment-161208960",
"id" => 161208960,
"issue_url" => "https://api.github.com/repos/elixir-lang/elixir/issues/4021",
"updated_at" => "2015-12-02T07:34:41Z",
"url" => "https://api.github.com/repos/elixir-lang/elixir/issues/comments/161208960",
"user" => %{"avatar_url" => "https://avatars.githubusercontent.com/u/9582?v=3",
"events_url" => "https://api.github.com/users/josevalim/events{/privacy}",
"followers_url" => "https://api.github.com/users/josevalim/followers",
"following_url" => "https://api.github.com/users/josevalim/following{/other_user}",
"gists_url" => "https://api.github.com/users/josevalim/gists{/gist_id}",
"gravatar_id" => "", "html_url" => "https://github.com/josevalim",
"id" => 9582, "login" => "josevalim",
"organizations_url" => "https://api.github.com/users/josevalim/orgs",
"received_events_url" => "https://api.github.com/users/josevalim/received_events",
"repos_url" => "https://api.github.com/users/josevalim/repos",
"site_admin" => false,
"starred_url" => "https://api.github.com/users/josevalim/starred{/owner}{/repo}",
"subscriptions_url" => "https://api.github.com/users/josevalim/subscriptions",
"type" => "User", "url" => "https://api.github.com/users/josevalim"}},
%{"body" => "@josevalim Hi, do you have any feedback?",
"created_at" => "2016-02-04T12:44:44Z",
"html_url" => "https://github.com/elixir-lang/elixir/pull/4021#issuecomment-179813056",
"id" => 179813056,
"issue_url" => "https://api.github.com/repos/elixir-lang/elixir/issues/4021",
"updated_at" => "2016-02-04T12:44:44Z",
"url" => "https://api.github.com/repos/elixir-lang/elixir/issues/comments/179813056",
"user" => %{"avatar_url" => "https://avatars.githubusercontent.com/u/34700?v=3",
"events_url" => "https://api.github.com/users/milmazz/events{/privacy}",
"followers_url" => "https://api.github.com/users/milmazz/followers",
"following_url" => "https://api.github.com/users/milmazz/following{/other_user}",
"gists_url" => "https://api.github.com/users/milmazz/gists{/gist_id}",
"gravatar_id" => "", "html_url" => "https://github.com/milmazz",
"id" => 34700, "login" => "milmazz",
"organizations_url" => "https://api.github.com/users/milmazz/orgs",
"received_events_url" => "https://api.github.com/users/milmazz/received_events",
"repos_url" => "https://api.github.com/users/milmazz/repos",
"site_admin" => false,
"starred_url" => "https://api.github.com/users/milmazz/starred{/owner}{/repo}",
"subscriptions_url" => "https://api.github.com/users/milmazz/subscriptions",
"type" => "User", "url" => "https://api.github.com/users/milmazz"}},
%{"body" => "@lexmag Thanks for your review, I already applied all the fixes that you suggested, please let me know what do you think.",
"created_at" => "2016-03-11T06:31:49Z",
"html_url" => "https://github.com/elixir-lang/elixir/pull/4021#issuecomment-195216523",
"id" => 195216523,
"issue_url" => "https://api.github.com/repos/elixir-lang/elixir/issues/4021",
"updated_at" => "2016-03-11T06:31:49Z",
"url" => "https://api.github.com/repos/elixir-lang/elixir/issues/comments/195216523",
"user" => %{"avatar_url" => "https://avatars.githubusercontent.com/u/34700?v=3",
"events_url" => "https://api.github.com/users/milmazz/events{/privacy}",
"followers_url" => "https://api.github.com/users/milmazz/followers",
"following_url" => "https://api.github.com/users/milmazz/following{/other_user}",
"gists_url" => "https://api.github.com/users/milmazz/gists{/gist_id}",
"gravatar_id" => "", "html_url" => "https://github.com/milmazz",
"id" => 34700, "login" => "milmazz",
"organizations_url" => "https://api.github.com/users/milmazz/orgs",
"received_events_url" => "https://api.github.com/users/milmazz/received_events",
"repos_url" => "https://api.github.com/users/milmazz/repos",
"site_admin" => false,
"starred_url" => "https://api.github.com/users/milmazz/starred{/owner}{/repo}",
"subscriptions_url" => "https://api.github.com/users/milmazz/subscriptions",
"type" => "User", "url" => "https://api.github.com/users/milmazz"}},
%{"body" => "I wonder if `ArgumentError` is the best choice here. I expect each `ArgumentError` to be related to a programmer error, but here it's used to handle user errors - providing wrong options. I think a simple `RuntimeError` or a custom one would be much better.",
"created_at" => "2016-03-11T08:07:40Z",
"html_url" => "https://github.com/elixir-lang/elixir/pull/4021#issuecomment-195246501",
"id" => 195246501,
"issue_url" => "https://api.github.com/repos/elixir-lang/elixir/issues/4021",
"updated_at" => "2016-03-11T08:08:10Z",
"url" => "https://api.github.com/repos/elixir-lang/elixir/issues/comments/195246501",
"user" => %{"avatar_url" => "https://avatars.githubusercontent.com/u/477062?v=3",
"events_url" => "https://api.github.com/users/michalmuskala/events{/privacy}",
"followers_url" => "https://api.github.com/users/michalmuskala/followers",
"following_url" => "https://api.github.com/users/michalmuskala/following{/other_user}",
"gists_url" => "https://api.github.com/users/michalmuskala/gists{/gist_id}",
"gravatar_id" => "", "html_url" => "https://github.com/michalmuskala",
"id" => 477062, "login" => "michalmuskala",
"organizations_url" => "https://api.github.com/users/michalmuskala/orgs",
"received_events_url" => "https://api.github.com/users/michalmuskala/received_events",
"repos_url" => "https://api.github.com/users/michalmuskala/repos",
"site_admin" => false,
"starred_url" => "https://api.github.com/users/michalmuskala/starred{/owner}{/repo}",
"subscriptions_url" => "https://api.github.com/users/michalmuskala/subscriptions",
"type" => "User", "url" => "https://api.github.com/users/michalmuskala"}},
%{"body" => "@michalmuskala I think any kind of error could be scaring and unhelpful if `parse!` is called from mix task. I believe more than half of the cases where `OptionParser` will be used is Mix task rather that pure scripts.\r\nI propose to provide `OptionParser.format_errors` function instead, then developer can decide what kind of error to use, otherwise they end up rescuing `ArgumentError` from `OptionParser` to reuse with the `Mix.raise`.",
"created_at" => "2016-03-11T12:28:47Z",
"html_url" => "https://github.com/elixir-lang/elixir/pull/4021#issuecomment-195348203",
"id" => 195348203,
"issue_url" => "https://api.github.com/repos/elixir-lang/elixir/issues/4021",
"updated_at" => "2016-03-11T12:41:16Z",
"url" => "https://api.github.com/repos/elixir-lang/elixir/issues/comments/195348203",
"user" => %{"avatar_url" => "https://avatars.githubusercontent.com/u/248290?v=3",
"events_url" => "https://api.github.com/users/lexmag/events{/privacy}",
"followers_url" => "https://api.github.com/users/lexmag/followers",
"following_url" => "https://api.github.com/users/lexmag/following{/other_user}",
"gists_url" => "https://api.github.com/users/lexmag/gists{/gist_id}",
"gravatar_id" => "", "html_url" => "https://github.com/lexmag",
"id" => 248290, "login" => "lexmag",
"organizations_url" => "https://api.github.com/users/lexmag/orgs",
"received_events_url" => "https://api.github.com/users/lexmag/received_events",
"repos_url" => "https://api.github.com/users/lexmag/repos",
"site_admin" => false,
"starred_url" => "https://api.github.com/users/lexmag/starred{/owner}{/repo}",
"subscriptions_url" => "https://api.github.com/users/lexmag/subscriptions",
"type" => "User", "url" => "https://api.github.com/users/lexmag"}},
%{"body" => "The goal is to have a custom exception and automatically handle it from Mix side. I will work on integrating those after this patch is merged. :)",
"created_at" => "2016-03-11T12:50:07Z",
"html_url" => "https://github.com/elixir-lang/elixir/pull/4021#issuecomment-195352219",
"id" => 195352219,
"issue_url" => "https://api.github.com/repos/elixir-lang/elixir/issues/4021",
"updated_at" => "2016-03-11T12:50:07Z",
"url" => "https://api.github.com/repos/elixir-lang/elixir/issues/comments/195352219",
"user" => %{"avatar_url" => "https://avatars.githubusercontent.com/u/9582?v=3",
"events_url" => "https://api.github.com/users/josevalim/events{/privacy}",
"followers_url" => "https://api.github.com/users/josevalim/followers",
"following_url" => "https://api.github.com/users/josevalim/following{/other_user}",
"gists_url" => "https://api.github.com/users/josevalim/gists{/gist_id}",
"gravatar_id" => "", "html_url" => "https://github.com/josevalim",
"id" => 9582, "login" => "josevalim",
"organizations_url" => "https://api.github.com/users/josevalim/orgs",
"received_events_url" => "https://api.github.com/users/josevalim/received_events",
"repos_url" => "https://api.github.com/users/josevalim/repos",
"site_admin" => false,
"starred_url" => "https://api.github.com/users/josevalim/starred{/owner}{/repo}",
"subscriptions_url" => "https://api.github.com/users/josevalim/subscriptions",
"type" => "User", "url" => "https://api.github.com/users/josevalim"}}]