Add snapshot_relative_subdir config option#53
Open
lukearndt wants to merge 1 commit intolevinmr:masterfrom
Open
Add snapshot_relative_subdir config option#53lukearndt wants to merge 1 commit intolevinmr:masterfrom
lukearndt wants to merge 1 commit intolevinmr:masterfrom
Conversation
Context: When `config.snapshot_dir` is set to `:relative` (the default option), rspec-snapshot stores snapshots in a location relative to the spec file. Prior to this commit, that relative snapshot location was hard-coded to a `__snapshots__` subdirectory and the application had no way to choose anything else. Changes: This commit adds a new config option that allows the caller to specify a subdirectory when `config.snapshot_dir` is set to `:relative`. The new config option supports the following values: - String: a path to a different subdirectory - nil: stores snapshot files in the same directory as each spec file In all cases, the caller can still store the snapshot files in a further subdirectory by calling `match_snapshot` with a nested snapshot name.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
When
config.snapshot_diris set to:relative(the default option),rspec-snapshot stores snapshots in a location relative to the spec file.
Prior to this commit, that relative snapshot location was hard-coded to
a
__snapshots__subdirectory and the application had no way to chooseanything else.
Changes:
This commit adds a new config option that allows the caller to specify
a subdirectory when
config.snapshot_diris set to:relative.The new config option supports the following values:
String: a path to a different subdirectory
nil: stores snapshot files in the same directory as each spec file
In all cases, the caller can still store the snapshot files in a further
subdirectory by calling
match_snapshotwith a nested snapshot name.