Skip to content

Revive CI #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmimura39 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Revive CI #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
765df70
Add Ruby 3.4 to CI
tmimura39 Dec 3, 2025
f435796
resolve RuboCop errors
tmimura39 Dec 3, 2025
0a4f0b4
fix broken snapshot
tmimura39 Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,31 +7,31 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['3.3', '3.2', '3.1', '3.0', '2.7']
ruby-version: ['3.4', '3.3', '3.2', '3.1', '3.0']
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@360dc864d5da99d54fcb8e9148c14a84b90d3e88
- uses: ruby/setup-ruby@8aeb6ff8030dd539317f8e1769a044873b56ea71
with:
ruby-version: ${{ matrix.ruby-version }}
- run: gem install bundler:2.4.22
- run: bundle install
- run: bundle exec rubocop

test:
needs: lint
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['3.3', '3.2', '3.1', '3.0', '2.7']
ruby-version: ['3.4', '3.3', '3.2', '3.1', '3.0']
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@360dc864d5da99d54fcb8e9148c14a84b90d3e88
- uses: ruby/setup-ruby@8aeb6ff8030dd539317f8e1769a044873b56ea71
with:
ruby-version: ${{ matrix.ruby-version }}
- run: gem install bundler:2.4.22
Expand Down
10 changes: 7 additions & 3 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require:
plugins:
- rubocop-rake
- rubocop-rspec

Expand Down Expand Up @@ -45,8 +45,8 @@ RSpec/ExampleLength:
Max: 10
RSpec/ExpectInHook:
Enabled: true
RSpec/FilePath:
Enabled: true
RSpec/ExpectInLet:
Enabled: false
RSpec/InstanceVariable:
Enabled: true
RSpec/LeakyConstantDeclaration:
Expand All @@ -65,6 +65,10 @@ RSpec/NestedGroups:
Max: 6
RSpec/ScatteredSetup:
Enabled: true
RSpec/SpecFilePathFormat:
Enabled: true
RSpec/SpecFilePathSuffix:
Enabled: true
RSpec/SubjectStub:
Enabled: true
RSpec/VerifiedDoubles:
Expand Down
8 changes: 4 additions & 4 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ gem 'bundler', '~> 2.3'
gem 'byebug'
gem 'pry-byebug'
gem 'rake', '~> 13.0'
gem 'rubocop', '~> 1.59'
gem 'rubocop-rake', '~> 0.6.0'
gem 'rubocop-rspec', '~> 2.16'
gem 'simplecov'
gem 'rubocop'
gem 'rubocop-rake'
gem 'rubocop-rspec'
gem 'simplecov'
2 changes: 1 addition & 1 deletion spec/rspec/snapshot/__snapshots__/diff_snapshot.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ expected: {

Diff:

@@ -2,10 +2,10 @@
@@ -2,9 +2,9 @@
 :foo => {
 :bar => [
 [0] 1,
Expand Down