Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grpcio to 1.62.1 for Apple silicon #288

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

julesvanrie
Copy link
Contributor

Fixes lewagon/teachers/issues/2164
Recurring setup problem on macos failing to build grpcio because wheel for 1.50.0 is not available on pypi.

Bumping to more recent version solves this.

Following packages depend on it:

  • google-cloud-bigquery (but only used in taxifare, separate env)
  • pandas-gbq (only used in one lecture, tested with new version: ok)
  • tensorflow-macos:
    • tested on CNN (challenge 1 mnist): OK
    • tested on RNN (weather): OK
    • in taxifare we don't fix the grpcio version so it uses most recent version and all works fine, so changing

Concluding: safe to bump this version after test on mac m1.

Fixes lewagon/teachers/issues/2164
Recurring setup problem on macos failing to build grpcio because wheel for 1.50.0 is not available on pypi.

Bumping to more recent version solves this.

Following packages depend on it:
- google-cloud-bigquery (but only used in taxifare, separate env)
- pandas-gbq (only used in one lecture, tested with new version: ok)
- tensorflow-macos:
  - tested on CNN (challenge 1 mnist): OK
  - tested on RNN (weather): OK
  - in taxifare we don't fix the grpcio version so it uses most recent version and all works fine, so changing

Concluding: safe to bump this version after test on mac m1.
@Eschults Eschults merged commit 8f9e270 into master Apr 10, 2024
1 check passed
@Eschults Eschults deleted the fix-grpcio-apple-silicon branch April 10, 2024 07:40
@Eschults
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants