Phase 0: plan + pre-flight artifacts for flight-research activation#12
Merged
lewisnsmith merged 4 commits intomainfrom Apr 25, 2026
Merged
Phase 0: plan + pre-flight artifacts for flight-research activation#12lewisnsmith merged 4 commits intomainfrom
lewisnsmith merged 4 commits intomainfrom
Conversation
Adds FlightDB.listSessionsWithFirstTurn() and annotation-with-context types to surface richer session metadata in `flight log list`. CLI gains --all/--run/--status filters. Small TUI detail/tree tweaks accompany the shared query changes.
- Full phased-execution design doc (Phases 0-4 parallel tracks, Phase 5 deferred) with 13 resolved decisions folded in from CEO/DX/Eng reviews - Phase 0 complete: package-name findings (PyPI flight taken -> flight-research; npm flight-proxy already owned), CLI surface ground-truthed at 36 subcommands, ExperimentConfig.experiment_id rename impact mapped - src/experiment-schema.ts stub — signature locked for Phase 2A implementation, follows the ensureEntriesTurnIdColumn pattern from src/query.ts:653 Why: unblocks 4-way parallel track execution planned for Phases 1-4.
Resolves PR #12 conflicts caused by the monorepo restructure (src/ -> packages/flight-proxy/src/). Ports the Phase 0 flight-research-activation artifacts onto the new layout: - packages/flight-proxy/src/experiment-schema.ts (stub, signature locked for Phase 2A) - docs/designs/flight-research-activation.md (unchanged path) Carries forward the 02a6668 "enrich flight log list" feature into the monorepo: - listSessionsWithFirstTurn() in packages/flight-proxy/src/query.ts - --all / --run / --status filters on `flight logs list` - --compact option on `flight logs verbose` - adapted banner names from `log` to `logs` (rename happened on main) Drops the experimental `log replay` (transcript viewer), `log replay-call`, and `log annotate` aliases from the branch -- they overlapped main's `logs replay` and top-level `annotate` commands. Verified: typecheck + lint pass on packages/flight-proxy.
CI lint failed on packages/flight-proxy/src/experiment-schema.ts:23 flagging `_db` as an unused parameter. The underscore prefix is the standard convention for intentionally-unused params (the function is a Phase 2A stub with a locked signature), but the eslint config didn't configure no-unused-vars to honor it. Add argsIgnorePattern of `^_` so the convention works as intended across the package. Verified: `npx eslint src/` exits 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/designs/flight-research-activation.md(Phases 0–4 parallel tracks, Phase 5 deferred) with 13 resolved decisions (D1–D13) folded in from CEO + DX + Eng reviews.flightis taken → falling back toflight-research; Python import name staysflight. npmflight-proxyalready owned bylewisnsmithat v1.3.1 — reuse, no reservation needed.flight log comparealready exists (src/cli.ts:452) — Phase 4A now promotes it top-level rather than greenfielding.ExperimentConfig.experiment_idrename impact (D6): mapped insrc/query.ts:114,232,312,492,496,618,664,1137,src/hooks.ts:107, plus test fixtures. Rename is cheaper than overloading semantics.src/experiment-schema.ts— stub with locked signature for the Phase 2A migration, following theensureEntriesTurnIdColumnprecedent (src/query.ts:653).Why
Unblocks 4-way parallel track execution planned for Phases 1–4. Every subsequent phase is independently shippable; agents can start Phase 1 tracks in parallel worktrees as soon as this lands.
Test plan
src/experiment-schema.tsimports cleanly (stub raisesError— by design, not yet called anywhere)npm run checkpasses (no code behavior changed)🤖 Generated with Claude Code