Fixes for heap corruption due to thread safety issue - #718
Open
TomasMorris wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks, I'll take a look next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
curl_easy_performfails, the handles get deallocated, but the caller of the method then tries to get the cookies from that same memory space, which is a use-after-free issue. This can cause heap corruption errors on Windows (and generally memory errors on any system). There is also a double-free issue withResponse._finalize_stream()that can cause concurrent deletes to be possible.Fix
Added an optional param
auto_cleanupthat lets the caller avoid cleanup if they intend to use the class after an errorAdded general thread safety around curl methods as they are specifically not promised to be thread safe.