feat: add status_forcelist to RetryStrategy - #782
Open
dokson wants to merge 2 commits into
Open
Conversation
Retry on retryable HTTP status codes (e.g. 429, 5xx) in addition to transport errors. Opt-in via RetryStrategy(status_forcelist=...), empty by default so behavior is unchanged. Honours the Retry-After header (seconds form) when present, otherwise uses the configured backoff. Applies to both Session and AsyncSession; the response is released before each retry to avoid leaking a handle/stream. Closes lexiforest#781
dokson
force-pushed
the
feat/retry-status-forcelist
branch
from
July 20, 2026 15:02
267da2c to
feb07c4
Compare
float() happily parses "inf", which would make the retry sleep forever. Only honour finite delta-seconds, anything else falls back to backoff. Also cover the stream=True + status_forcelist path in tests, sync and async (async on max_clients=1 so a leaked handle would hang).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry on retryable HTTP status codes (429, 5xx) in addition to transport errors. Opt-in via
RetryStrategy(status_forcelist=...), empty by default so existing behavior is unchanged. HonoursRetry-After(seconds form) when present, otherwise the configured backoff. Works for bothSessionandAsyncSession; the response is released before each retry so no handle/stream leaks.Closes #781