fix(tests): silence websockets deprecation warnings - #783
Open
dokson wants to merge 1 commit into
Open
Conversation
uvicorn's default ws="auto" loads the legacy websockets_impl, deprecated under websockets 15, emitting DeprecationWarnings even though the test servers are HTTP-only (the ws tests use websockets.serve directly). Set ws="none" on those Configs. Also close the session in test_create_session_out_of_async so it no longer leaks an unclosed event loop (ResourceWarning).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silence the websockets
DeprecationWarnings in the test suite. uvicorn's defaultws="auto"loads the legacywebsockets_impl(deprecated under websockets 15) at server startup, even though the test servers are HTTP-only (the ws tests usewebsockets.servedirectly), so setws="none"on thoseConfigs.Also close the session in
test_create_session_out_of_asyncso it no longer leaks an unclosed event loop (ResourceWarning).Checklist