ci: check impersonate targets stay in sync with the pinned binary - #808
Open
dokson wants to merge 1 commit into
Open
ci: check impersonate targets stay in sync with the pinned binary#808dokson wants to merge 1 commit into
dokson wants to merge 1 commit into
Conversation
scripts/check_browsers.py fetches the pinned curl.patch and fails if any browser target it declares is missing from BrowserTypeLiteral or NATIVE_IMPERSONATE_TARGETS, so a new version in the binary can't go unexposed. Wired into the lint job. Parses via AST, no build needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a new browser lands in the pinned
curl-impersonate, nothing flags it if you forget to add it to curl_cffi. It just silently is not exposed until someone hits it at runtime.scripts/check_browsers.pyfetches the pinnedcurl.patchand fails if any browser target it declares is missing fromBrowserTypeLiteralorNATIVE_IMPERSONATE_TARGETS. Wired into the lint job; parses via AST so no build is needed.Checklist