fix: handle missing errorIndication in StatusInformation#242
Open
saschabuehrle wants to merge 1 commit into
Open
fix: handle missing errorIndication in StatusInformation#242saschabuehrle wants to merge 1 commit into
saschabuehrle wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #241
rfc3412.prepare_data_elementscan raise aStatusInformationwith onlysendPduHandleand noerrorIndicationkey (line 875 in rfc3412.py, the else-branch whenreportableFlagis false). Whencmdgen.process_response_pducatches this, it doesstatusInformation["errorIndication"]which throws aKeyError.Switched both lookups in
cmdgen.pyto.get("errorIndication", errind.requestTimedOut)so the callback still fires with a sensible error instead of crashing.-- saschabuehrle