Skip to content

fix: revise kafka sink conf/metrics#3494

Merged
ngjaying merged 7 commits intolf-edge:masterfrom
Yisaer:revise_kafka_writer
Feb 7, 2025
Merged

fix: revise kafka sink conf/metrics#3494
ngjaying merged 7 commits intolf-edge:masterfrom
Yisaer:revise_kafka_writer

Conversation

@Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jan 9, 2025

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
@codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 71.10%. Comparing base (0c6f4a0) to head (b4b2cac).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
extensions/impl/kafka/sink.go 58.06% 11 Missing and 2 partials ⚠️
metrics/metrics.go 0.00% 5 Missing ⚠️
extensions/impl/sql/sink.go 50.00% 3 Missing ⚠️
extensions/impl/kafka/source.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3494      +/-   ##
==========================================
+ Coverage   71.07%   71.10%   +0.04%     
==========================================
  Files         416      417       +1     
  Lines       48001    48042      +41     
==========================================
+ Hits        34112    34159      +47     
+ Misses      11219    11215       -4     
+ Partials     2670     2668       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer marked this pull request as ready for review January 9, 2025 07:20
@Yisaer Yisaer requested a review from ngjaying January 9, 2025 07:20
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying February 7, 2025 03:59
@ngjaying ngjaying merged commit b77de3d into lf-edge:master Feb 7, 2025
57 of 58 checks passed
Yisaer added a commit to Yisaer/ekuiper that referenced this pull request Feb 25, 2025
Signed-off-by: Song Gao <disxiaofei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants