Skip to content

fix(sink): fix sink buffer length metrics#3508

Merged
ngjaying merged 1 commit intolf-edge:master-1.14from
Yisaer:minor_change
Jan 15, 2025
Merged

fix(sink): fix sink buffer length metrics#3508
ngjaying merged 1 commit intolf-edge:master-1.14from
Yisaer:minor_change

Conversation

@Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jan 15, 2025

  1. Fix sink buffer length metrics
  2. SQL source close rows after read

Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying January 15, 2025 01:15
@ngjaying ngjaying changed the title fix: fix metrics and code fix(sink): fix sink buffer length metrics Jan 15, 2025
@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master-1.14@59495ba). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             master-1.14    #3508   +/-   ##
==============================================
  Coverage               ?   63.34%           
==============================================
  Files                  ?      354           
  Lines                  ?    40772           
  Branches               ?        0           
==============================================
  Hits                   ?    25827           
  Misses                 ?    12694           
  Partials               ?     2251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying merged commit 8bb7d04 into lf-edge:master-1.14 Jan 15, 2025
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants