Skip to content

fix(rest): parse resp skip compression #3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ngjaying merged 1 commit into from
Jan 15, 2025
Merged

fix(rest): parse resp skip compression #3511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/io/http/rest_sink.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2024 EMQ Technologies Co., Ltd.
// Copyright 2024-2025 EMQ Technologies Co., Ltd.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -146,7 +146,7 @@ func (r *RestSink) Collect(ctx api.StreamContext, item api.RawTuple) error {
method, u)
} else {
logger.Debugf("rest sink got response %v", resp)
_, b, err := r.parseResponse(ctx, resp, "", r.config.DebugResp, false)
_, b, err := r.parseResponse(ctx, resp, "", r.config.DebugResp, true)
// do not record response body error as it is not an error in the sink action.
if err != nil && !strings.HasPrefix(err.Error(), BODY_ERR) {
if strings.HasPrefix(err.Error(), BODY_ERR) {
Expand Down
Loading