fix(cache): add to disk cache already have some#3512
Merged
ngjaying merged 1 commit intolf-edge:master-1.14from Jan 16, 2025
Merged
fix(cache): add to disk cache already have some#3512ngjaying merged 1 commit intolf-edge:master-1.14from
ngjaying merged 1 commit intolf-edge:master-1.14from
Conversation
The cache are: [memCache disk bufferWritePage], if disk or bufferWritePage already exist, do not write to memCache Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master-1.14 #3512 +/- ##
==============================================
Coverage ? 63.36%
==============================================
Files ? 355
Lines ? 40813
Branches ? 0
==============================================
Hits ? 25859
Misses ? 12698
Partials ? 2256 ☔ View full report in Codecov by Sentry. |
Yisaer
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache are: [memCache disk bufferWritePage], if disk or bufferWritePage already exist, do not write to memCache