feat(trial): replace websocket with sse#3991
Merged
ngjaying merged 3 commits intolf-edge:masterfrom Feb 2, 2026
Merged
Conversation
ngjaying
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3991 +/- ##
==========================================
+ Coverage 71.34% 71.38% +0.05%
==========================================
Files 457 460 +3
Lines 52899 53105 +206
==========================================
+ Hits 37737 37908 +171
- Misses 12247 12267 +20
- Partials 2915 2930 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ngjaying
force-pushed
the
ruletest
branch
7 times, most recently
from
bf524b8 to
7f3aa82
Compare
ngjaying
force-pushed
the
ruletest
branch
5 times, most recently
from
26ba35e to
9bb397e
Compare
Signed-off-by: Jiyong Huang <[email protected]>
Track SSE connections per endpoint using sseEndpointContext to ensure all active client connections are properly closed when trial rule is deleted. Matches WebSocket implementation pattern. Add unit tests to verify connections close properly when endpoint is unregistered. Signed-off-by: Jiyong Huang <[email protected]>
Signed-off-by: Jiyong Huang <[email protected]>
Yisaer
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.