fix(test): resolve data races in redis mock and nexmark#3995
Closed
ngjaying wants to merge 3 commits intolf-edge:masterfrom
Closed
fix(test): resolve data races in redis mock and nexmark#3995ngjaying wants to merge 3 commits intolf-edge:masterfrom
ngjaying wants to merge 3 commits intolf-edge:masterfrom
Conversation
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
1. Fix data race in pkg/mock/test_source.go used by Redis tests. 2. Fix data race in global slice access in internal/io/nexmark/event.go. Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3995 +/- ##
==========================================
+ Coverage 71.92% 71.97% +0.05%
==========================================
Files 457 457
Lines 52717 52727 +10
==========================================
+ Hits 37913 37947 +34
+ Misses 11877 11861 -16
+ Partials 2927 2919 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes data race in pkg/mock/test_source.go (used by Redis tests) and global variable race in internal/io/nexmark/event.go.