feat(pb): support schemas from a directory#4006
Merged
Conversation
ngjaying
changed the title
ngjaying
force-pushed
the
feat/mande/protobuf-dir-schema
branch
from
79cfa9b to
afbe059
Compare
The protobuf schema parser now supports directories by passing the directory path as the schema file. It will parse all '.proto' files within the directory, allowing for schemas split across multiple files. Signed-off-by: Jiyong Huang <huangjy@emqx.io>
ngjaying
force-pushed
the
feat/mande/protobuf-dir-schema
branch
from
afbe059 to
60dbe7b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4006 +/- ##
==========================================
- Coverage 71.87% 71.78% -0.09%
==========================================
Files 460 460
Lines 53183 53248 +65
==========================================
- Hits 38224 38223 -1
- Misses 12024 12078 +54
- Partials 2935 2947 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yisaer
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support configuring a directory path as the schema file for protobuf adapters. When a directory is provided, the parser will collect and parse all
.protofiles within it, allowing for schemas split across multiple files.Changes
Scanmethod inschema/protobuf.goto recognize subdirectories as valid schema IDs.collectProtoFileshelper to gather paths for all.protofiles in a directory.Inferin schema andNewConverterin converter to parse all collected files into a unified descriptor pool and search across all resulting file descriptors for the target message.