Skip to content

fix(planner): mocksource emit name for unnest#4008

Merged
ngjaying merged 1 commit intolf-edge:masterfrom
Yisaer:emit_mock
Mar 3, 2026
Merged

fix(planner): mocksource emit name for unnest#4008
ngjaying merged 1 commit intolf-edge:masterfrom
Yisaer:emit_mock

Conversation

@Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Mar 2, 2026

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.81%. Comparing base (5dee73c) to head (8daf716).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4008      +/-   ##
==========================================
- Coverage   71.87%   71.81%   -0.07%     
==========================================
  Files         460      460              
  Lines       53183    53190       +7     
==========================================
- Hits        38224    38194      -30     
- Misses      12024    12054      +30     
- Partials     2935     2942       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yisaer Yisaer requested a review from ngjaying March 2, 2026 04:50
Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This perfectly aligns with the finding that while the $ prefix is necessary to prevent global schema store corruption and topology ID collisions during rule tests, it shouldn't leak as the emitter name into the downstream data flow. If it does, operators like unnest or field projections that expect the original stream name will fail to find their fields. Explicitly adding an EmitterOp to restore the emitter name while keeping the internal node name mocked is the correct fix.

@ngjaying ngjaying changed the title fix: fix mocksource emit name fix(planner): mocksource emit name for unnest Mar 3, 2026
@ngjaying ngjaying merged commit a4c5685 into lf-edge:master Mar 3, 2026
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants