fix(planner): mocksource emit name for unnest#4008
Conversation
Signed-off-by: Song Gao <disxiaofei@163.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4008 +/- ##
==========================================
- Coverage 71.87% 71.81% -0.07%
==========================================
Files 460 460
Lines 53183 53190 +7
==========================================
- Hits 38224 38194 -30
- Misses 12024 12054 +30
- Partials 2935 2942 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ngjaying
left a comment
There was a problem hiding this comment.
LGTM. This perfectly aligns with the finding that while the $ prefix is necessary to prevent global schema store corruption and topology ID collisions during rule tests, it shouldn't leak as the emitter name into the downstream data flow. If it does, operators like unnest or field projections that expect the original stream name will fail to find their fields. Explicitly adding an EmitterOp to restore the emitter name while keeping the internal node name mocked is the correct fix.
No description provided.