Open
Conversation
Contributor
Author
|
There is a minor issue in the CI pipeline related to a unit test. However, it does not appear to be caused by the changes in this PR. I ran the same codebase without my modifications and the error is still reproducible, so we can conclude that it is unrelated to this change? Let me know if you already have context on it. |
Signed-off-by: Elia Renzoni <elia.renzoni03@gmail.com>
Signed-off-by: Elia Renzoni <elia.renzoni03@gmail.com>
3b383e7 to
d655909
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4025 +/- ##
==========================================
+ Coverage 70.63% 70.66% +0.02%
==========================================
Files 459 459
Lines 53324 53449 +125
==========================================
+ Hits 37665 37765 +100
- Misses 12719 12749 +30
+ Partials 2940 2935 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ngjaying
This PR introduces support for the
DEFAULTclause. At the moment, the implementation covers only the following data types:If this approach looks good to you, I can extend the support to all the other available data types.
From a design perspective, and to avoid large refactors, the
DEFAULTclause is currently enabled only whenSTRICT_VALIDATIONis set totrue. This means the feature relies on the preprocessor to work properly.Let me know your thoughts or if you'd like me to adjust anything.
Related Issue: #2293