Skip to content

Fix an issue of edge-node clustering interface using logical-label#5720

Open
naiming-zededa wants to merge 1 commit intolf-edge:masterfrom
naiming-zededa:naiming-cluster-intfname
Open

Fix an issue of edge-node clustering interface using logical-label#5720
naiming-zededa wants to merge 1 commit intolf-edge:masterfrom
naiming-zededa:naiming-cluster-intfname

Conversation

@naiming-zededa
Copy link
Copy Markdown
Contributor

@naiming-zededa naiming-zededa commented Mar 31, 2026

Description

  • if the device has logical-label for the interface, zedkube is converting the logical-label into the interface Ifname to be used for kubernetes flannel interface

PR dependencies

How to test and validate this PR

  • Make the device model, have the interface using logical-label which is different from the Ifname
  • onboard the devices using that model
  • configure the edge-node clustering, and select the intf w/ logical-label to use
  • make sure the cluster is up and working

Changelog notes

Fix an issue of edge-node clustering interface using logical-label

PR Backports

  • 16.0-stable

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

For backport PRs (remove it if it's not a backport):

  • I've added a reference link to the original PR
  • PR's title follows the template

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

- if the device has logical-label for the interface, zedkube is
  converting the logical-label into the interface Ifname to be used for
  kubernetes flannel interface

Signed-off-by: naiming-zededa <naiming@zededa.com>
@milan-zededa milan-zededa added the bug Something isn't working label Mar 31, 2026
@milan-zededa
Copy link
Copy Markdown
Contributor

I think that this bug fix should be backported to 16.0 LTS

@naiming-zededa naiming-zededa added the stable Should be backported to stable release(s) label Mar 31, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.87%. Comparing base (2281599) to head (69546ae).
⚠️ Report is 378 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5720       +/-   ##
===========================================
+ Coverage   19.52%   29.87%   +10.34%     
===========================================
  Files          19       18        -1     
  Lines        3021     2417      -604     
===========================================
+ Hits          590      722      +132     
+ Misses       2310     1549      -761     
- Partials      121      146       +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working stable Should be backported to stable release(s)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants