Move kube-save-var-lib under vault#5745
Draft
andrewd-zededa wants to merge 1 commit intolf-edge:masterfrom
Draft
Move kube-save-var-lib under vault#5745andrewd-zededa wants to merge 1 commit intolf-edge:masterfrom
andrewd-zededa wants to merge 1 commit intolf-edge:masterfrom
Conversation
Contributor
Author
|
Can someone add stable label? |
github-actions
bot
requested review from
eriknordmark,
naiming-zededa and
zedi-pramodh
andrewd-zededa
force-pushed
the
eve-k-save-var-lib-vault
branch
from
3118513 to
e8f11e4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5745 +/- ##
==========================================
+ Coverage 19.52% 28.34% +8.81%
==========================================
Files 19 18 -1
Lines 3021 2417 -604
==========================================
+ Hits 590 685 +95
+ Misses 2310 1588 -722
- Partials 121 144 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eriknordmark
reviewed
Apr 5, 2026
Contributor
Author
|
Hold on this merge, seeing an issue in testing. |
andrewd-zededa
force-pushed
the
eve-k-save-var-lib-vault
branch
from
e8f11e4 to
d0c10db
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
andrewd-zededa
force-pushed
the
eve-k-save-var-lib-vault
branch
3 times, most recently
from
de18fd3 to
b6008d1
Compare
In kube service container startup (setup_prereqs), after vault is ready begin migrating kube-save-var-lib with the same process used to snapshot and restore it currently. Cannot perform a simple rename as src and dest can be on separate fs. Copy with archive to preserve mode, ownership and timestamps. Signed-off-by: Andrew Durbin <andrewd@zededa.com>
andrewd-zededa
force-pushed
the
eve-k-save-var-lib-vault
branch
from
b6008d1 to
625ec66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In kube service container startup (setup_prereqs), after vault is ready begin
migrating kube-save-var-lib with the same process used to snapshot and restore
it currently.
Cannot perform a simple rename as src and dest can be on separate fs.
Copy with archive to preserve mode, ownership and timestamps.
PR dependencies
None
How to test and validate this PR
eve enter kube)Changelog notes
PR Backports
Checklist
And the last but not least:
check them.
Please, check the boxes above after submitting the PR in interactive mode.