Skip to content

Conversation

@lhstrh
Copy link
Member

@lhstrh lhstrh commented Mar 31, 2025

No description provided.

@lhstrh lhstrh requested a review from hokeun March 31, 2025 01:43
Copy link
Member

@hokeun hokeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one question: You say "npm publish will require two-factor authorization." But who has authority to publish this? How does one get authority?

@lhstrh
Copy link
Member Author

lhstrh commented Apr 1, 2025

I'm the owner of the package on npm and can authorize others to publish. I recently authorized @hokeun (and he requested these instructions).

@edwardalee edwardalee merged commit 6cd04d5 into master Apr 1, 2025
4 checks passed
@hokeun
Copy link
Member

hokeun commented Apr 1, 2025

I'm the owner of the package on npm and can authorize others to publish. I recently authorized @hokeun (and he requested these instructions).

Thanks Marten! @lhstrh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants