fix(provider): MistralTextToSpeechModel.available_voices reads only the first page#151
Open
kunalk16 wants to merge 2 commits intolfnovo:mainfrom
Open
fix(provider): MistralTextToSpeechModel.available_voices reads only the first page#151kunalk16 wants to merge 2 commits intolfnovo:mainfrom
kunalk16 wants to merge 2 commits intolfnovo:mainfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
kunalk16
force-pushed
the
fix-mistral-voices-pagination
branch
from
057e37a to
60c5e86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes: #148
What does this implement/fix? Explain your changes.
Existing behavior is that the code makes a call to the GET
/audio/voicesAPI call and consumes the data from the response. It does not consider paginated responses. Hence, the modification is the PR is to consider pagination using the offset and limit parameters as per the documentation in https://docs.mistral.ai/api/endpoint/audio/voices#operation-list_voices_v1_audio_voices_getAny other comments?
Test added, ruff/mypy passes, added documentation link.