Skip to content

Minor build changes and two new _container_add() overrides for Gtk4 #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbalmer wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Minor build changes and two new _container_add() overrides for Gtk4 #344

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c96035
Merge pull request #1 from pavouk/master
mbalmer May 17, 2020
605d3ce
Merge branch 'lgi-devs:master' into master
mbalmer Jul 12, 2025
9ca717e
Add Gtk4 _container_add() overrides for Gtk.Grid and
Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lgi/override/Gtk.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ if Gtk._version == '4.0' then

--- CONTAINER CLASSES
--- GTK4 Has removed the Container abstract class.
--- This means Boxes, Grids and other layout widgets
--- This means Boxes, Grids and other layout widgets
--- Must now add children using their own specific methods.

--- Gtk.Box overrides
Expand All @@ -648,7 +648,14 @@ if Gtk._version == '4.0' then
--- will be `append()`-ed
--- in order of appearance.
Gtk.Box._container_add = Gtk.Box.append

Gtk.Grid._container_add = function (grid, twidget)
grid:attach(twidget[1], twidget.column - 1, twidget.row - 1,
twidget.width or 1, twidget.height or 1)
end

Gtk.ApplicationWindow._container_add = function (window, child)
window:set_child(child)
end
end

--------------------------------- Gtk-2 workarounds
Expand Down