Support object stores: CutSet.from_shar(in_dir='s3://...')#1558
Open
pzelasko wants to merge 14 commits into
Open
Support object stores: CutSet.from_shar(in_dir='s3://...')#1558pzelasko wants to merge 14 commits into
CutSet.from_shar(in_dir='s3://...')#1558pzelasko wants to merge 14 commits into
Conversation
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
pzelasko
changed the title
CutSet.from_shar(in_dir='s3://...')
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>
Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>
karpnv
reviewed
Mar 30, 2026
| if not key.startswith(listing_prefix): | ||
| return False | ||
| key = key[len(listing_prefix) :] | ||
| return bool(key) and "/" not in key |
Collaborator
There was a problem hiding this comment.
Why do we need this limitation "/" not in key ?
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.