fix: handle truncated batch stream with sequential GET fallback#1566
Merged
pzelasko merged 1 commit intoApr 14, 2026
Merged
Conversation
gaikwadabhishek
commented
Apr 14, 2026
gaikwadabhishek
commented
Contributor
- catch StopIteration during batch result iteration and fall back to individual GET requests instead of crashing the DataLoader worker
- use batch_stream_failed flag to skip dead iterator for remaining objects
- reuse existing _get_object_from_moss_in() retry path for recovery
- update test to verify fallback behavior instead of expecting crash
- catch StopIteration during batch result iteration and fall back to individual GET requests instead of crashing the DataLoader worker - use batch_stream_failed flag to skip dead iterator for remaining objects - reuse existing _get_object_from_moss_in() retry path for recovery - update test to verify fallback behavior instead of expecting crash Signed-off-by: Abhishek Gaikwad <gaikwadabhishek1997@gmail.com>
gaikwadabhishek
force-pushed
the
fix-batch-stream-truncation
branch
from
c6d9534 to
62d7f29
Compare
pzelasko
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.