[feat] Add in a group of meta metrics to allow submetric running - #129
Merged
Conversation
This allows users to run multiple submetrics, which is useful for perturbation studies to compare whether transitions are being properly captured.
This allows users to define the genes that regulate the start and end and which genes will be important towards its trajectory. This is a metric to allow them to see how useful it is.
This adds in the check against the random baseline as well.
ehuan2
marked this pull request as ready for review
June 8, 2026 14:49
Allows us to have filtered the cell types and timepoint index for perturbations, en route for the final meta perturbation.
This adds the filtered cells ability so that the changes are more realistic (i.e. starting from a certain cell type population).
aosakwe
requested changes
Jun 9, 2026
aosakwe
left a comment
aosakwe
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Only change worth tweaking is the number of random genes used. the simplest for now could be to set it to be the max number of knock-ins/knock-ons seen across the submetrics. Just to prevent the number of genes being a confounder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to run multiple submetrics, which is useful for perturbation studies to compare whether transitions are being properly captured.