Skip to content

[fix] Fix eval only running on a single dataset - #134

Merged
ehuan2 merged 1 commit into
mainfrom
eric/fix-multiple-dataset-meta-metric
Jul 6, 2026
Merged

[fix] Fix eval only running on a single dataset#134
ehuan2 merged 1 commit into
mainfrom
eric/fix-multiple-dataset-meta-metric

Conversation

@ehuan2

@ehuan2 ehuan2 commented Jul 6, 2026

Copy link
Copy Markdown
Member

Previously, I messed up by having eval() return right after the first one. This makes the change so that it doesn't simply return right after the first one and instead actually goes and runs everything.

Previously, I messed up by having eval() return right after the first
one. This makes the change so that it doesn't simply return right after
the first one and instead actually goes and runs everything.
@ehuan2
ehuan2 requested a review from aosakwe July 6, 2026 20:44

@aosakwe aosakwe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ehuan2
ehuan2 merged commit 53f3af2 into main Jul 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants