Skip to content

change outerHeight to getBoundingClientRect #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mafisz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change outerHeight to getBoundingClientRect #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jquery.matchHeight.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@

// find the max height (including padding, but not margin)
if ($that.outerHeight(false) > targetHeight) {
targetHeight = $that.outerHeight(false);
targetHeight = $that.getBoundingClientRect().height;
}

// revert styles
Expand All @@ -259,7 +259,7 @@
});
} else {
// if target set, use the height of the target element
targetHeight = opts.target.outerHeight(false);
targetHeight = opts.target[0].getBoundingClientRect().height;
}

// iterate the row and apply the height to all elements
Expand Down