Replace native select with FormatSelectDropdown in PasteSessionForm #3938

devin-ai-integration · 2025-10-29T09:27:18Z

Issue

resolve: https://github.com/route06/liam-internal/issues/5973

Why is this change needed?

This PR unifies the UI by replacing the native <select> element in PasteSessionFormPresenter with the existing FormatSelectDropdown component, addressing feedback from PR #3921. Additionally, it makes the dropdown content-sized instead of full-width per user request.

What changed?

Component Integration:

Replaced native <select> with FormatSelectDropdown component
Removed isFormatType helper function (no longer needed)
Removed formatSelectId from useId() hook
Wrapped dropdown in a div with formatDropdown class for content-sized width

CSS Changes:

Removed unused CSS classes: formatSelect, formatLabel, formatSelectorWrapper (39 lines removed)
Added formatDropdown class with align-self: flex-start and width: fit-content to prevent stretching in the flex container

⚠️ Important Review Points

Disabled State Handling: The original native select had disabled={isPending} but FormatSelectDropdown doesn't accept a disabled prop. Please verify the dropdown is appropriately non-interactive when the form is in pending state.
Label Removal: The "Schema Format" text label was removed since FormatSelectDropdown displays the selected format inline. Please confirm this is the desired UX.
Width Behavior: The dropdown now uses width: fit-content with the component's existing min-width: 127px. If the minimum width should also be removed, please let me know.
Visual Testing Needed: Changes were validated with lint/typecheck but not visually tested. Please verify in the preview:
- Dropdown appearance and spacing look correct
- Keyboard navigation still works
- Accessibility remains intact

Link to Devin run: https://app.devin.ai/sessions/91b8ec857810412a9ddd095d321a8ebe
Requested by: @MH4GF ([email protected])

- Replace native <select> element with FormatSelectDropdown component - Remove unused isFormatType helper function - Remove unused formatSelectId from useId hook - Remove unused CSS classes: formatSelect, formatLabel, formatSelectorWrapper - Maintain existing functionality with selectedFormat and onFormatChange props Co-Authored-By: [email protected] <[email protected]>

devin-ai-integration · 2025-10-29T09:27:21Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR that start with 'DevinAI' or '@devin'.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

giselles-ai · 2025-10-29T09:27:24Z

Finished running flow.

Step	Status	Updated(UTC)
1	✅	Oct 29, 2025 9:27am
2	✅	Oct 29, 2025 9:28am
3	✅	Oct 29, 2025 9:28am

vercel · 2025-10-29T09:27:24Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
liam-app	Ready	Preview	Comment	Oct 31, 2025 7:12am
liam-assets	Ready	Preview	Comment	Oct 31, 2025 7:12am
liam-docs	Ready	Preview	Comment	Oct 31, 2025 7:12am
liam-erd-sample	Ready	Preview		Oct 31, 2025 7:12am
liam-storybook	Ready	Preview	Comment	Oct 31, 2025 7:12am

supabase · 2025-10-29T09:27:32Z

Updates to Preview Branch (devin/1761729947-use-format-select-dropdown) ↗︎

Deployments	Status	Updated
Database	✅	Fri, 31 Oct 2025 07:06:35 UTC
Services	✅	Fri, 31 Oct 2025 07:06:35 UTC
APIs	✅	Fri, 31 Oct 2025 07:06:35 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks	Status	Updated
Configurations	✅	Fri, 31 Oct 2025 07:06:37 UTC
Migrations	⚠️	Fri, 31 Oct 2025 07:06:37 UTC
Seeding	✅	Fri, 31 Oct 2025 07:06:37 UTC
Edge Functions	✅	Fri, 31 Oct 2025 07:06:37 UTC

⚠️ Warning — Applied out-of-order migrations: [frontend/internal-packages/db/supabase/migrations/20250610120000_extend_add_project_with_schema_file_path.sql]

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

coderabbitai · 2025-10-29T09:28:18Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

giselles-ai · 2025-10-29T09:28:52Z

Check changeset necessity

Status: NOT REQUIRED

Reason:

Changes are confined to frontend/apps/app, which maps to the ignored package "@liam-hq/app".
No modifications to target packages that require changesets: @liam-hq/cli, @liam-hq/erd-core, @liam-hq/schema, or @liam-hq/ui.
Although the UI changes are user-facing (replacing a native select with FormatSelectDropdown, label removal), they affect only the app and do not impact published packages or external consumers.
No API, performance, or behavioral changes in any publishable package.

Changeset (copy & paste):

# No changeset required — changes affect only the ignored package "@liam-hq/app".

- Wrap FormatSelectDropdown in a div with formatDropdown class - Add CSS to set align-self: flex-start and width: fit-content - This prevents the dropdown from stretching to full width in the flex container Co-Authored-By: [email protected] <[email protected]>

Co-Authored-By: [email protected] <[email protected]>

Copilot

Pull Request Overview

This PR replaces the native <select> element in PasteSessionForm with the existing FormatSelectDropdown component to unify the UI, and makes the dropdown content-sized instead of full-width.

Key changes:

Replaced native <select> with FormatSelectDropdown component
Removed 39 lines of unused CSS for the old select element
Made dropdown content-sized using width: fit-content

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
PasteSessionFormPresenter.tsx	Replaced native select with FormatSelectDropdown component and removed helper function
PasteSessionFormPresenter.module.css	Removed CSS classes for native select and added formatDropdown class for content-sized width

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

NoritakaIkeda

That's a great refactoring! Thank you!

devin-ai-integration bot assigned MH4GF Oct 29, 2025

vercel bot deployed to Preview – liam-assets October 29, 2025 09:32 View deployment

vercel bot deployed to Preview – liam-storybook October 29, 2025 09:32 View deployment

vercel bot deployed to Preview – liam-app October 29, 2025 09:38 View deployment

vercel bot temporarily deployed to Preview – liam-erd-sample October 31, 2025 06:59 Inactive

vercel bot deployed to Preview – liam-assets October 31, 2025 07:00 View deployment

vercel bot deployed to Preview – liam-storybook October 31, 2025 07:00 View deployment

vercel bot deployed to Preview – liam-app October 31, 2025 07:04 View deployment

Merge main branch and resolve conflicts

aac6c96

Co-Authored-By: [email protected] <[email protected]>

vercel bot deployed to Preview – liam-storybook October 31, 2025 07:06 View deployment

vercel bot deployed to Preview – liam-assets October 31, 2025 07:06 View deployment

vercel bot deployed to Preview – liam-erd-sample October 31, 2025 07:06 View deployment

vercel bot deployed to Preview – liam-docs October 31, 2025 07:07 View deployment

vercel bot deployed to Preview – liam-app October 31, 2025 07:12 View deployment

MH4GF approved these changes Nov 4, 2025

View reviewed changes

MH4GF marked this pull request as ready for review November 4, 2025 02:19

MH4GF requested a review from a team as a code owner November 4, 2025 02:19

MH4GF requested review from NoritakaIkeda, Copilot, junkisai and sasamuku and removed request for a team November 4, 2025 02:19

Copilot AI reviewed Nov 4, 2025

View reviewed changes

NoritakaIkeda approved these changes Nov 4, 2025

View reviewed changes

NoritakaIkeda added this pull request to the merge queue Nov 4, 2025

Merged via the queue into main with commit c9b95ed Nov 4, 2025
34 checks passed

NoritakaIkeda deleted the devin/1761729947-use-format-select-dropdown branch November 4, 2025 02:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Replace native select with FormatSelectDropdown in PasteSessionForm #3938

Replace native select with FormatSelectDropdown in PasteSessionForm #3938

devin-ai-integration bot commented Oct 29, 2025 •

edited by MH4GF

Loading

Uh oh!

devin-ai-integration bot commented Oct 29, 2025

Uh oh!

giselles-ai bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

vercel bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

supabase bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 29, 2025

Review skipped

Uh oh!

giselles-ai bot commented Oct 29, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

NoritakaIkeda left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Replace native select with FormatSelectDropdown in PasteSessionForm #3938

Replace native select with FormatSelectDropdown in PasteSessionForm #3938

Conversation

devin-ai-integration bot commented Oct 29, 2025 • edited by MH4GF Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Why is this change needed?

What changed?

⚠️ Important Review Points

Uh oh!

devin-ai-integration bot commented Oct 29, 2025

🤖 Devin AI Engineer

Uh oh!

giselles-ai bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supabase bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 29, 2025

Review skipped

Uh oh!

giselles-ai bot commented Oct 29, 2025

Check changeset necessity

Reason:

Changeset (copy & paste):

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

NoritakaIkeda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

devin-ai-integration bot commented Oct 29, 2025 •

edited by MH4GF

Loading

giselles-ai bot commented Oct 29, 2025 •

edited

Loading

vercel bot commented Oct 29, 2025 •

edited

Loading

supabase bot commented Oct 29, 2025 •

edited

Loading