Fix: Build client assets in GitHub Actions workflows #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add src/Client/dist/* to .gitignore to exclude built artifacts from source control - Remove previously committed dist files from git tracking - Update CI and Publish workflows to build client assets before .NET build - Add Node.js 22 setup step to both workflows - Add .nvmrc file to specify Node version 22 for consistent development environments - Add engines field to package.json requiring Node >=22 This ensures the NuGet package includes compiled JavaScript files by building them during CI/CD, preventing issues where dist folder lacks compiled assets. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures that compiled JavaScript assets are included in the NuGet package by building client assets during CI/CD workflows. The changes prevent issues where the dist folder would lack compiled assets by explicitly building them before the .NET build step.
Key Changes:
- Configure Node.js version 22 requirements via
.nvmrcandpackage.jsonengines field - Update CI and Publish workflows to build client assets before .NET operations
- Bump package version to 2.7.1
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/XperienceCommunity.Sustainability.csproj | Increments package version to 2.7.1 |
| src/Client/package.json | Adds Node.js >=22 engine requirement |
| .nvmrc | Specifies Node version 22 for consistent development environments |
| .github/workflows/publish.yml | Adds Node.js setup and client asset build steps before .NET build |
| .github/workflows/ci.yml | Adds Node.js setup and client asset build steps before .NET build |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the NuGet package includes compiled JavaScript files by building them during CI/CD, preventing issues where dist folder lacks compiled assets.
🤖 Generated with Claude Code