Refactored codebase#6
Open
liamzebedee wants to merge 1 commit into
Open
Conversation
Owner
Author
|
@squishykid I want this on my desk by Monday. |
|
(╯°□°)╯︵ ┻━┻ |
|
Needs more test coverage b4 i can approve |
Renamed: - Model -> Simulation Extracted: - FunctionPlots - InsulinPumpModel - BodyMetabolismModel - plotly helpers - form helpers (debouncers) - compose helper New: - Helpers for parsing events (event_parsing)
4f17176 to
55f8978
Compare
Owner
Author
|
@squishykid can confirm I have been running this system in production and like me it has 9 9's uptime. |
|
Declining because it’s getting stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I'm attempting to refactor the codebase. The previous iteration was largely a monolith of two files - the frontend app and the simulation model.
Some details of the refactoring directory structure are in
REFACTOR.md.The model file was extracted into the following:
The frontend file was refactored into the following:
Originally, the goal was to refactor frontend state. During this iteration, I realised that the state was a reasonable contained concern, compared to the rest of the codebase. Hence, the project structure was refactored instead.