This repository was archived by the owner on Oct 9, 2025. It is now read-only.
fix: fixed invalid routes, removed docker compose, and some README up…#2
Merged
fix: fixed invalid routes, removed docker compose, and some README up…#2
Conversation
Comment on lines
+81
to
84
| uses: goreleaser/goreleaser-action@v6 | ||
| with: | ||
| distribution: goreleaser | ||
| version: latest | ||
| args: release --clean |
There was a problem hiding this comment.
The 'version' parameter has been removed from the goreleaser-action configuration. This parameter is required even in v6 of the action to specify which goreleaser version to use.
Suggested change
| uses: goreleaser/goreleaser-action@v6 | |
| with: | |
| distribution: goreleaser | |
| version: latest | |
| args: release --clean | |
| uses: goreleaser/goreleaser-action@v6 | |
| with: | |
| distribution: goreleaser | |
| version: latest | |
| args: release --clean |
Comment on lines
+126
to
+128
| except KeyboardInterrupt: | ||
| print("\n🛑 Shutting down server gracefully...") | ||
| exit(0) |
There was a problem hiding this comment.
The exit(0) call in the KeyboardInterrupt handler is redundant since Python would exit cleanly anyway when a KeyboardInterrupt is caught at the top level. Consider removing it for simplicity.
Suggested change
| except KeyboardInterrupt: | |
| print("\n🛑 Shutting down server gracefully...") | |
| exit(0) | |
| except KeyboardInterrupt: | |
| print("\n🛑 Shutting down server gracefully...") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dates