--disable-optional nvc++ warning fixes #4298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And this breaks `--disable-optional --disable-paranoid-warnings --disable-werror` builds with them.
This fixes an nvc++ warning with --disable-amr, and avoids running or reporting tests that are redundant in that configuration.
This fixes a nvc++ unused parameter warning for me, and in a better way than the fix we'd previously used for Nemesis.
|
Job Min gcc on 7c16d1a : invalidated by @jwpeterson Try again now that PETSc has been updated on the Min gcc recipe |
|
Job Test mac on 7c16d1a : invalidated by @jwpeterson Try again now that PETSc 3.24 deprecation warnings have been fixed |
jwpeterson
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No serious bugs here, but the tests/ fixes should very slightly reduce runtime by removing a few degraded unit tests from configurations that don't support running those tests for real.