Poly fixups WIP #4359
Open
Poly fixups WIP #4359
+240
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiudGiud
commented
Dec 23, 2025
| const Point x_i = side.point(0); | ||
| const Point n_i = | ||
| (side.point(1) - side.point(0)).cross | ||
| -(side.point(1) - side.point(0)).cross |
Contributor
Author
There was a problem hiding this comment.
@roystgnr can I please get a fact check on this line (rest is WIP)?
I'm assuming that if the nodes are ordered in the counter-clockwise direction, the normal should point up. Is that correct?
Then placing my index along P0P1 and the major following Pn-1P0 (what this formula says?) I would get down, so instead I do
P1P0 x Pn-1P0 or similarly Pn-1P0 x P0P1 and I get up (the desired result)
am I getting this wrong?
Contributor
Author
There was a problem hiding this comment.
ok the (center - center_side) (pointing inside) is flipping the sign. So changing it is wrong here, I ll change it back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on top of the hexagon tiling PR, ignore that content for now! It's in another PR