cpr::MultiPerform fixes - #1047 and #1186 #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And correct a mistake in a comment
Should fix tests on Fedora
Anohkka
force-pushed
the
multiperform-fix
branch
from
954be4b to
f3a9fa3
Compare
Anohkka
changed the title
This curl_multi_remove_handle call is a bit more error-prone with the changes we've made, and skipping over sessions in the cleanup process leads to sessions that can't be used due to isUsedInMultiPerform being set to true, along with other potential, undesired consequences as a result of improper cleanup. We could remove the curl_multi_remove_handle call entirely, but that, too, will cause issues if any part of the code throws after we've added handles to the multi stack and before removing them. It's not something that's very likely to happen with the existing code, but that could easily change in the future and the call to that function doesn't seem to be doing any harm, aside from some wasted CPU cycles.
COM8
approved these changes
Sep 20, 2025
Member
COM8
left a comment
COM8
left a comment
There was a problem hiding this comment.
Wonderful! Thank you very much for fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #1047 and #1186. I took the liberty of changing cpr::Multiperform code to use structured bindings for better readability as well, but I can just revert that commit if so desired.
Multiple Invocations of cpr::MultiPerform Segfault #1047 was happening because easy handles added to a multi stack can't normally be reused, but we can work around that by removing and adding handles to the multi stack.
cpr::MultiperformAssignment Not Working #1186 was caused by the default move constructor and move assignment operator copying over the invalidcurrent_interceptor_andfirst_interceptor_iterators from the moved-from MultiPerform object.